Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canny stack #1511

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Canny stack #1511

merged 2 commits into from
Nov 29, 2024

Conversation

rolalaro
Copy link

  • Deactivated the stack check and potential change by default, it is now an option
  • Corrected a compilation warning intutorial-canny

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 53.83%. Comparing base (2df7042) to head (6f52d6a).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
modules/core/src/image/vpCannyEdgeDetection.cpp 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
+ Coverage   53.82%   53.83%   +0.01%     
==========================================
  Files         442      442              
  Lines       53869    53871       +2     
==========================================
+ Hits        28995    29004       +9     
+ Misses      24874    24867       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle
Copy link
Contributor

@rolalaro Perfect. Thanks

@fspindle fspindle merged commit ae840eb into lagadic:master Nov 29, 2024
78 checks passed
@rolalaro rolalaro deleted the canny_stack branch December 4, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants